Messages in this thread | | | Date | Wed, 26 Dec 2012 12:47:21 +0900 | From | gshark <> | Subject | Re: [PATCH] regulator: lp8755: Fix mask for pchip->mphase |
| |
2012년 12월 26일 11:12, Axel Lin 쓴 글: > According to lp8755.h: > enum lp8755_mphase_config { > MPHASE_CONF0, > MPHASE_CONF1, > MPHASE_CONF2, > MPHASE_CONF3, > MPHASE_CONF4, > MPHASE_CONF5, > MPHASE_CONF6, > MPHASE_CONF7, > MPHASE_CONF8, > MPHASE_CONF_MAX > }; > > MPHASE_CONF_MAX is 9, the mask for pchip->mphase should be 0x17. > Otherwise, we cannot differentiate MPHASE_CONF0 and MPHASE_CONF8. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > Hi Daniel, > I don't have the datasheet, can you check if this patch is correct? > > BTW, I'm Axel, not Alex. > > Regards, > Axel > drivers/regulator/lp8755.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/lp8755.c b/drivers/regulator/lp8755.c > index 06a82e2..6d5a11d 100644 > --- a/drivers/regulator/lp8755.c > +++ b/drivers/regulator/lp8755.c > @@ -301,7 +301,7 @@ static int lp8755_init_data(struct lp8755_chip *pchip) > ret = lp8755_read(pchip, 0x3D, ®val); > if (ret < 0) > goto out_i2c_error; > - pchip->mphase = regval & 0x07; > + pchip->mphase = regval & 0x17; > > /* set default data based on multi-phase config */ > for (icnt = 0; icnt < mphase_buck[pchip->mphase].nreg; icnt++) { Hi Axel.
According to the new datasheet, it has 9 multi-phase mode from 0 to 8 and it takes 4bits in the register.
the mask for pchip->mphase should be 0x0F.
Thank you for your comments Axel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |