lkml.org 
[lkml]   [2012]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH review] f2fs: Don't assign e_id in f2fs_acl_from_disk
From
Date
2012-12-25 (화), 16:41 -0800, Eric W. Biederman:
> With user namespaces enabled building f2fs fails with:
>
> CC fs/f2fs/acl.o
> fs/f2fs/acl.c: In function ‘f2fs_acl_from_disk’:
> fs/f2fs/acl.c:85:21: error: ‘struct posix_acl_entry’ has no member named ‘e_id’
> make[2]: *** [fs/f2fs/acl.o] Error 1
> make[2]: Target `__build' not remade because of errors.
>
> e_id is a backwards compatibility field only used for file systems
> that haven't been converted to use kuids and kgids. When the posix
> acl tag field is neither ACL_USER nor ACL_GROUP assigning e_id is
> unnecessary. Remove the assignment so f2fs will build with user
> namespaces enabled.
>
> Cc: Jaegeuk Kim <jaegeuk.kim@samsung.com>
> Cc: Namjae Jeon <namjae.jeon@samsung.com>
> Cc: Amit Sahrawat <a.sahrawat@samsung.com>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

Acked-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>

--
Jaegeuk Kim
Samsung
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-12-26 04:01    [W:0.031 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site