Messages in this thread | | | Date | Wed, 26 Dec 2012 01:51:05 +0100 | Subject | Re: [PATCH 4/4 v2] net/smsc911x: Provide common clock functionality | From | Linus Walleij <> |
| |
On Fri, Dec 21, 2012 at 12:41 PM, Lee Jones <lee.jones@linaro.org> wrote:
> + if (IS_ERR(pdata->clk)) { > + ret = clk_prepare_enable(pdata->clk); > + if (ret < 0) > + netdev_err(ndev, "failed to enable clock %d\n", ret); > + }
I think you got all of these backwards now, shouldn't it be if (!IS_ERR(pdata->clk)) { } ...?
It's late here but enlighten me if I don't get it.
> + if (IS_ERR(pdata->clk)) > + clk_disable_unprepare(pdata->clk);
Dito.
> + /* Request clock */ > + pdata->clk = clk_get(&pdev->dev, NULL); > + if (IS_ERR(pdata->clk)) > + netdev_warn(ndev, "couldn't get clock %li\n", PTR_ERR(pdata->clk));
This one seems correct though.
> + /* Free clock */ > + if (IS_ERR(pdata->clk)) { > + clk_put(pdata->clk); > + pdata->clk = NULL; > + }
Should be !IS_ERR()
Yours, Linus Walleij
| |