Messages in this thread | | | Date | Mon, 24 Dec 2012 16:01:47 +0530 | Subject | Re: [PATCH] rtc: add RTC driver for TPS80031/TPS80032 | From | "devendra.aaru" <> |
| |
Hello,
On Mon, Dec 24, 2012 at 3:58 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote: > Thanks Devendra for quick review. > > Following are my response specific to query. > > I will post the next patch for taking care of comments. > >
thanks :)
> > > On Monday 24 December 2012 03:32 PM, devendra.aaru wrote: >> >> Hello, >> >> On Mon, Dec 24, 2012 at 3:04 PM, Laxman Dewangan<ldewangan@nvidia.com> >> wrote: >>> >>> Add an RTC driver for TPS80031/TPS80032 chips by TI. >>> This driver supports: >>> - Setting and getting time and date. >>> - Setting and reading alarm time. >>> - Alarm and interrupt functionlity. >>> >> >>> + >>> + if (alrm->enabled&& (seconds< epoch_start)) { >> >> its better to have this check in the core itself rather duplicating >> everywhere, but i think the core already have this check, will you >> please check ? > > > Yes, it is there in __rtc_set_alarm() of interface.c file. I will remove > this in next patch. >
ok.
> > >>> + >>> +static const struct dev_pm_ops tps80031_pm_ops = { >>> + SET_SYSTEM_SLEEP_PM_OPS(tps80031_rtc_suspend, >>> tps80031_rtc_resume) >> >> say we dont have enabled CONFIG_PM_SLEEP, will we get an compiler error ? > > > No compilation error. This is already taken care in on pm.h. >
ok good to know, sorry for disturbing you with this comment.
>> Please read the FAQ at http://www.tux.org/lkml/ > >
| |