Messages in this thread |  | | Date | Mon, 24 Dec 2012 19:18:35 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH 25/25] ipc: don't use [delayed_]work_pending() |
| |
Hello, Borislav.
On Mon, Dec 24, 2012 at 08:32:58PM +0100, Borislav Petkov wrote: > Ok, understood. I have only one question: how do you make sure > schedule_work() is used only in cold paths?
Hot and cold are relative terms and unless someone is doing things like invoking queue_work() from high-frequency interrupt handler, the level of overhead from queue_work() isn't likely to matter. The best way to deal with such hot paths would differ depending on the specifics of each hot path - ie. bouncing to workqueue from IRQ handler would be better handled by threaded IRQ handlers.
At this point, especially given how all of work_pending() users are way too cold for any of this to matter, I don't think we need to worry about this.
> Btw, there's __cancel_delayed_work() which is not used anywhere and it > could be deleted AFAICT.
Yeah, there are several interfaces which are being deprecated. They'll be gone in a few cycles.
Thanks.
-- tejun
|  |