lkml.org 
[lkml]   [2012]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 21/25] tty/max3100: don't use [delayed_]work_pending()
    Date
    There's no need to test whether a (delayed) work item in pending
    before queueing, flushing or cancelling it. Most uses are unnecessary
    and quite a few of them are buggy.

    Remove unnecessary pending tests from max3100. Only compile tested.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Jiri Slaby <jslaby@suse.cz>
    ---
    Please let me know how this patch should be routed. I can take it
    through the workqueue tree if necessary.

    Thanks.

    drivers/tty/serial/max3100.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
    index 7ce3197..dd6277e 100644
    --- a/drivers/tty/serial/max3100.c
    +++ b/drivers/tty/serial/max3100.c
    @@ -179,8 +179,7 @@ static void max3100_work(struct work_struct *w);

    static void max3100_dowork(struct max3100_port *s)
    {
    - if (!s->force_end_work && !work_pending(&s->work) &&
    - !freezing(current) && !s->suspending)
    + if (!s->force_end_work && !freezing(current) && !s->suspending)
    queue_work(s->workqueue, &s->work);
    }

    --
    1.8.0.2


    \
     
     \ /
      Last update: 2012-12-22 05:21    [W:4.044 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site