Messages in this thread |  | | From | Kukjin Kim <> | Subject | RE: [PATCH 23/25] video/exynos: don't use [delayed_]work_pending() | Date | Fri, 21 Dec 2012 19:05:51 -0800 |
| |
Tejun Heo wrote: > > There's no need to test whether a (delayed) work item in pending > before queueing, flushing or cancelling it. Most uses are unnecessary > and quite a few of them are buggy. > > Remove unnecessary pending tests from exynos_dp_core. Only compile > tested. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Kukjin Kim <kgene.kim@samsung.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
> --- > Please let me know how this patch should be routed. I can take it > through the workqueue tree if necessary. > Cc'ed Jingoo and Florian.
Now the exynos dp driver are being handled by Jingoo so let's waiting for his opinion to take this by himself or not.
- Kukjin Kim
> Thanks. > > drivers/video/exynos/exynos_dp_core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/exynos/exynos_dp_core.c > b/drivers/video/exynos/exynos_dp_core.c > index 28fd686..3002a6a 100644 > --- a/drivers/video/exynos/exynos_dp_core.c > +++ b/drivers/video/exynos/exynos_dp_core.c > @@ -1121,8 +1121,7 @@ static int __devexit exynos_dp_remove(struct > platform_device *pdev) > > disable_irq(dp->irq); > > - if (work_pending(&dp->hotplug_work)) > - flush_work(&dp->hotplug_work); > + flush_work(&dp->hotplug_work); > > if (pdev->dev.of_node) { > if (dp->phy_addr) > @@ -1144,8 +1143,7 @@ static int exynos_dp_suspend(struct device *dev) > struct exynos_dp_platdata *pdata = dev->platform_data; > struct exynos_dp_device *dp = dev_get_drvdata(dev); > > - if (work_pending(&dp->hotplug_work)) > - flush_work(&dp->hotplug_work); > + flush_work(&dp->hotplug_work); > > if (dev->of_node) { > if (dp->phy_addr) > -- > 1.8.0.2
|  |