| From | Tejun Heo <> | Subject | [PATCH 05/25] devfreq: don't use [delayed_]work_pending() | Date | Fri, 21 Dec 2012 17:56:55 -0800 |
| |
There's no need to test whether a (delayed) work item in pending before queueing, flushing or cancelling it. Most uses are unnecessary and quite a few of them are buggy.
Remove unnecessary pending tests from devfreq. Only compile tested.
Signed-off-by: Tejun Heo <tj@kernel.org> Cc: MyungJoo Ham <myungjoo.ham@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> --- Please let me know how this patch should be routed. I can take it through the workqueue tree if necessary.
Thanks.
drivers/devfreq/devfreq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 53766f3..fb4695e 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -291,8 +291,7 @@ void devfreq_monitor_resume(struct devfreq *devfreq) if (!devfreq->stop_polling) goto out; - if (!delayed_work_pending(&devfreq->work) && - devfreq->profile->polling_ms) + if (devfreq->profile->polling_ms) queue_delayed_work(devfreq_wq, &devfreq->work, msecs_to_jiffies(devfreq->profile->polling_ms)); devfreq->stop_polling = false; -- 1.8.0.2
|