| Date | Fri, 21 Dec 2012 23:03:15 +0100 (CET) | From | Jesper Juhl <> | Subject | Re: [PATCH] kvm tools: remove unneeded checks in qcow code |
| |
On Thu, 20 Dec 2012, Sasha Levin wrote:
> We already know q!=NULL at that point, no need to retest. > Right, and even if it was ==NULL then 'free(NULL)' is guaranteed to be a NOP, so it would still be fine.
Reviewed-by: Jesper Juhl <jj@chaosbits.net>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com> > --- > tools/kvm/disk/qcow.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tools/kvm/disk/qcow.c b/tools/kvm/disk/qcow.c > index ee2992e..64a2550 100644 > --- a/tools/kvm/disk/qcow.c > +++ b/tools/kvm/disk/qcow.c > @@ -1361,8 +1361,7 @@ free_header: > if (q->header) > free(q->header); > free_qcow: > - if (q) > - free(q); > + free(q); > > return NULL; > } > @@ -1492,8 +1491,7 @@ free_header: > if (q->header) > free(q->header); > free_qcow: > - if (q) > - free(q); > + free(q); > > return NULL; > } >
-- Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please.
|