lkml.org 
[lkml]   [2012]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched/rt: Move cpu rq properties from "struct rt_rq" to "struct rq"
From
Date
On Fri, 2012-12-21 at 10:35 +0400, Kirill Tkhai wrote:
>
>
> entity_1->my_q_1
> /
> /
> rq->rt -entity_2->my_q_2
> \
> \
> entity_n->my_q_n
>
>
> I say about child rt_rqs (my_q_1....my_q_n). They don't have rt_nr_total, rt_nr_migratory, overloaded and pushable_tasks.
> The only use of overloaded, for example, is "rq->rt.overloaded". The same with other variables.

You're missing the point. rt_rq is not just for entities, it's the
encapsulation of the rt class.

Now if you want to encapsulate the rt sched group, then you could add a
new struct and put that into the rt_rq struct and use that for all the
group functions. But please don't just cludder the rq struct with rt
specific data. The rt_rq was created as a container for the rt class.

-- Steve




\
 
 \ /
  Last update: 2012-12-21 14:21    [W:0.266 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site