lkml.org 
[lkml]   [2012]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm: do not sleep in balance_pgdat if there's no i/o congestion
From
On Thu, Dec 20, 2012 at 7:25 AM, Zlatko Calusic <zlatko.calusic@iskon.hr> wrote:
> static unsigned long balance_pgdat(pg_data_t *pgdat, int order,
> int *classzone_idx)
> {
> - int all_zones_ok;
> + struct zone *unbalanced_zone;

nit: less hunks if not erase that mark

Hillf
> unsigned long balanced;
> int i;
> int end_zone = 0; /* Inclusive. 0 = ZONE_DMA */
> @@ -2580,7 +2580,7 @@ loop_again:
> unsigned long lru_pages = 0;
> int has_under_min_watermark_zone = 0;
>
> - all_zones_ok = 1;
> + unbalanced_zone = NULL;
> balanced = 0;
>
> /*
> @@ -2719,7 +2719,7 @@ loop_again:
> }
>
> if (!zone_balanced(zone, testorder, 0, end_zone)) {
> - all_zones_ok = 0;
> + unbalanced_zone = zone;
> /*
> * We are still under min water mark. This
> * means that we have a GFP_ATOMIC allocation
> @@ -2752,7 +2752,7 @@ loop_again:
> pfmemalloc_watermark_ok(pgdat))
> wake_up(&pgdat->pfmemalloc_wait);
>
> - if (all_zones_ok || (order && pgdat_balanced(pgdat, balanced, *classzone_idx)))
> + if (!unbalanced_zone || (order && pgdat_balanced(pgdat, balanced, *classzone_idx)))
> break; /* kswapd: all done */
> /*
> * OK, kswapd is getting into trouble. Take a nap, then take
> @@ -2762,7 +2762,7 @@ loop_again:
> if (has_under_min_watermark_zone)
> count_vm_event(KSWAPD_SKIP_CONGESTION_WAIT);
> else
> - congestion_wait(BLK_RW_ASYNC, HZ/10);
> + wait_iff_congested(unbalanced_zone, BLK_RW_ASYNC, HZ/10);
> }
>
> /*
> @@ -2781,7 +2781,7 @@ out:
> * high-order: Balanced zones must make up at least 25% of the node
> * for the node to be balanced
> */
> - if (!(all_zones_ok || (order && pgdat_balanced(pgdat, balanced, *classzone_idx)))) {
> + if (unbalanced_zone && (!order || !pgdat_balanced(pgdat, balanced, *classzone_idx))) {
> cond_resched();
>
> try_to_freeze();
> -- 1.7.10.4


\
 
 \ /
  Last update: 2012-12-21 13:21    [W:0.265 / U:1.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site