Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 08/18] sched: consider runnable load average in move_tasks | Date | Fri, 21 Dec 2012 13:43:43 +0900 |
| |
On Wed, 12 Dec 2012 14:26:44 +0800, Alex Shi wrote: > On 12/12/2012 12:41 PM, Preeti U Murthy wrote: >> Also why can't p->se.load_avg_contrib be used directly? as a return >> value for task_h_load_avg? since this is already updated in >> update_task_entity_contrib and update_group_entity_contrib. > > No, only non task entity goes to update_group_entity_contrib. not task > entity.
???
But task entity goes to __update_task_entity_contrib()?
/* Compute the current contribution to load_avg by se, return any delta */ static long __update_entity_load_avg_contrib(struct sched_entity *se) { long old_contrib = se->avg.load_avg_contrib;
if (entity_is_task(se)) { __update_task_entity_contrib(se); } else { __update_tg_runnable_avg(&se->avg, group_cfs_rq(se)); __update_group_entity_contrib(se); }
return se->avg.load_avg_contrib - old_contrib; }
Thanks, Namhyung
| |