lkml.org 
[lkml]   [2012]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 09/11] x86/head64.c: Early update ucode in 64-bit
From
On Thu, Dec 20, 2012 at 11:48 AM, Fenghua Yu <fenghua.yu@intel.com> wrote:
> From: Fenghua Yu <fenghua.yu@intel.com>
>
> This updates ucode on BSP in 64-bit mode. Paging and virtual address are
> working now.
>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---
> arch/x86/kernel/head64.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
> index e1cb611..1ccbaf1 100644
> --- a/arch/x86/kernel/head64.c
> +++ b/arch/x86/kernel/head64.c
> @@ -26,6 +26,7 @@
> #include <asm/kdebug.h>
> #include <asm/e820.h>
> #include <asm/bios_ebda.h>
> +#include <asm/microcode.h>
>
> /*
> * Manage page tables very early on.
> @@ -179,6 +180,11 @@ void __init x86_64_start_kernel(char * real_mode_data)
> }
> load_idt((const struct desc_ptr *)&idt_descr);
>
> + /*
> + * Load microcode early on BSP.
> + */
> + load_ucode_bsp(__va(real_mode_data));
> +
> copy_bootdata(__va(real_mode_data));

can you make load_ucode_bsp take boot_param directly instead of
real_mode_data. ?

could be


copy_bootdata(__va(real_mode_data));
+
+ /* Load microcode early on BSP. */
+ load_ucode_bsp(&boot_params);
+

because copy_bootdata, already copy boot_params...

Thanks

Yinghai


\
 
 \ /
  Last update: 2012-12-21 06:01    [W:0.114 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site