Messages in this thread | | | Date | Fri, 21 Dec 2012 04:21:50 +0200 | From | Ido Yariv <> | Subject | Re: [RFCv2 11/11] remoteproc: Support virtio config space. |
| |
Hi Sjur,
On Fri, Dec 14, 2012 at 05:07:00PM +0100, Sjur Brændeland wrote: > Support virtio configuration space and device status and > feature negotiation with remote device. This virtio device > can now access the resource table in shared memory. > > Signed-off-by: Sjur Brændeland <sjur.brandeland@stericsson.com> > ---
...
> +void rproc_virtio_get(struct virtio_device *vdev, unsigned offset, > + void *buf, unsigned len) > +{ > + struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); > + void *cfg = &rvdev->rsc->vring[rvdev->rsc->num_of_vrings]; > + memcpy(buf, cfg + offset, len); > +} > + > +void rproc_virtio_set(struct virtio_device *vdev, unsigned offset, > + const void *buf, unsigned len) > +{ > + struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); > + void *cfg = &rvdev->rsc->vring[rvdev->rsc->num_of_vrings]; > + memcpy(cfg + offset, buf, len); > }
Perhaps verify the offset and length to avoid overwriting memory?
Thanks, Ido. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |