lkml.org 
[lkml]   [2012]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases
Date


> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Thursday, December 20, 2012 9:51 PM
> To: Liu, Chuansheng
> Cc: lrg@ti.com; perex@perex.cz; tiwai@suse.de; alsa-devel@alsa-project.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ASoC: dapm: Fix the unpaired runtime_get/put cases
>
> On Thu, Dec 20, 2012 at 06:37:26AM +0000, Liu, Chuansheng wrote:
>
> > Meanwhile, is it useful to add one warning there for that case?
> > After all, in probing, set the bias to _STANDBY even idle_bias_off == 1, and
> calling get_runtime_sync(), it
> > will let the code more obscure. So giving a warning there to indicate the
> driver:
> > it is not suggested that in probing, set the bias to _STANDBY even
> idle_bias_off == 1.
>
> Probably, send a patch please. Like I say it is possible to start off
> in _STANDBY providing the driver grabs the runtime PM reference too but
> I can't think of any reason for doing that so the warning seems sensible.
The patch https://lkml.org/lkml/2012/12/20/506 has been sent for giving warning
in that case. Thanks your reviewing.


\
 
 \ /
  Last update: 2012-12-21 03:01    [W:0.070 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site