lkml.org 
[lkml]   [2012]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] virtio_console: correct error message on failure of debugfs_create_dir
    Date
    debugfs_create_dir() returns NULL if it fails, there's little point in
    calling PTR_ERR on it.

    Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
    ---
    drivers/char/virtio_console.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
    index c594cb1..490b70e 100644
    --- a/drivers/char/virtio_console.c
    +++ b/drivers/char/virtio_console.c
    @@ -2212,10 +2212,9 @@ static int __init init(void)
    }

    pdrvdata.debugfs_dir = debugfs_create_dir("virtio-ports", NULL);
    - if (!pdrvdata.debugfs_dir) {
    - pr_warning("Error %ld creating debugfs dir for virtio-ports\n",
    - PTR_ERR(pdrvdata.debugfs_dir));
    - }
    + if (!pdrvdata.debugfs_dir)
    + pr_warn("Error creating debugfs dir for virtio-ports\n");
    +
    INIT_LIST_HEAD(&pdrvdata.consoles);
    INIT_LIST_HEAD(&pdrvdata.portdevs);

    --
    1.8.0


    \
     
     \ /
      Last update: 2012-12-21 02:01    [W:4.341 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site