| Date | Thu, 20 Dec 2012 11:18:03 -0800 | From | Tejun Heo <> | Subject | Re: [PATCH] cgroup: remove redundant check |
| |
On Thu, Dec 20, 2012 at 02:11:31PM -0500, Sasha Levin wrote: > We already know that 'event' is non-NULL, remove the redundant check. > > Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
I don't know. I kinda like that test there. It's not an error path and tearing down everything which could have been allocated. If the test not being used is bothering, convert return -ENOMEM to goto fail?
-- tejun
|