Messages in this thread Patch in this message | | | Date | Thu, 20 Dec 2012 11:59:21 -0800 | From | tip-bot for Sasha Levin <> | Subject | [tip:x86/urgent] x86, efi: correct precedence of operators in setup_efi_pci |
| |
Commit-ID: 886d751a2ea99a160f2d0a472231566d9cb0cf58 Gitweb: http://git.kernel.org/tip/886d751a2ea99a160f2d0a472231566d9cb0cf58 Author: Sasha Levin <sasha.levin@oracle.com> AuthorDate: Thu, 20 Dec 2012 14:11:33 -0500 Committer: H. Peter Anvin <hpa@linux.intel.com> CommitDate: Thu, 20 Dec 2012 11:47:14 -0800
x86, efi: correct precedence of operators in setup_efi_pci
With the current code, the condition in the if() doesn't make much sense due to precedence of operators.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com> Link: http://lkml.kernel.org/r/1356030701-16284-25-git-send-email-sasha.levin@oracle.com Cc: Matt Fleming <matt.fleming@intel.com> Cc: Matthew Garrett <mjg@redhat.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Seth Forshee <seth.forshee@canonical.com> Signed-off-by: H. Peter Anvin <hpa@linux.intel.com> --- arch/x86/boot/compressed/eboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index b1942e2..18e329c 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b/arch/x86/boot/compressed/eboot.c @@ -302,7 +302,7 @@ static efi_status_t setup_efi_pci(struct boot_params *params) if (status != EFI_SUCCESS) continue; - if (!attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM) + if (!(attributes & EFI_PCI_IO_ATTRIBUTE_EMBEDDED_ROM)) continue; if (!pci->romimage || !pci->romsize)
| |