Messages in this thread | | | Date | Thu, 20 Dec 2012 13:06:26 +0000 | From | Alan Cox <> | Subject | Re: [PATCH] n_gsm.c: add tx_lock in gsm_send |
| |
On Thu, 20 Dec 2012 12:13:07 +0000 "Xiao, Jin" <jin.xiao@intel.com> wrote:
> Alan, > > Thanks. But the comment makes me confused. As we see, gsm->output is called by gsm_data_kick too, and it's in the tx_lock...
That would be a bug too or I guess we could finally give in on trying to keep tty write paths not using spin_lock_irq and fix any oddments that blow up. That might actually be the right thing to do as its caused problems in other places too, and the USB tty drivers are now well behaved.
Your patch doesn't make it any worse however so I agree it might as well go in.
Alan
| |