Messages in this thread | | | Date | Sun, 02 Dec 2012 12:53:25 -0500 | From | Rik van Riel <> | Subject | Re: [PATCH 2/2, v2] mm/migration: Make rmap_walk_anon() and try_to_unmap_anon() more scalable |
| |
On 12/02/2012 10:12 AM, Ingo Molnar wrote:
> Rename anon_vma_[un]lock() => anon_vma_[un]lock_write(), > to make it clearer that it's an exclusive write-lock in > that case - suggested by Rik van Riel.
... close, but you forgot to actually rename the unlock function :)
> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 7f5a552..81a9dee 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -101,7 +101,7 @@ extern void __split_huge_page_pmd(struct mm_struct *mm, pmd_t *pmd); > #define wait_split_huge_page(__anon_vma, __pmd) \ > do { \ > pmd_t *____pmd = (__pmd); \ > - anon_vma_lock(__anon_vma); \ > + anon_vma_lock_write(__anon_vma); \ > anon_vma_unlock(__anon_vma); \ > BUG_ON(pmd_trans_splitting(*____pmd) || \
-- All rights reversed
| |