lkml.org 
[lkml]   [2012]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2] thp: fix anononymous page accounting in fallback path for COW of HZP
    From
    On Fri, Nov 30, 2012 at 11:03 PM, Kirill A. Shutemov
    <kirill.shutemov@linux.intel.com> wrote:
    > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
    >
    > Don't forget to account newly allocated page in fallback path for
    > copy-on-write of huge zero page.
    >

    What about fallback path in do_huge_pmd_wp_page_fallback()?
    I think we should also account newly allocated page in it.

    > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    > ---
    > mm/huge_memory.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
    > index 57f0024..9d6f521 100644
    > --- a/mm/huge_memory.c
    > +++ b/mm/huge_memory.c
    > @@ -1164,6 +1164,7 @@ static int do_huge_pmd_wp_zero_page_fallback(struct mm_struct *mm,
    > pmd_populate(mm, pmd, pgtable);
    > spin_unlock(&mm->page_table_lock);
    > put_huge_zero_page();
    > + inc_mm_counter(mm, MM_ANONPAGES);
    >
    > mmu_notifier_invalidate_range_end(mm, mmun_start, mmun_end);
    >
    > --
    > 1.7.11.7
    >

    --
    Regards,
    --Bob


    \
     
     \ /
      Last update: 2012-12-03 05:01    [W:3.172 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site