lkml.org 
[lkml]   [2012]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -next] drm: tegra: fix missing unlock on error
    On Sun, Dec 02, 2012 at 05:25:05AM -0500, Wei Yongjun wrote:
    > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
    >
    > Add the missing unlock before return from function host1x_drm_init()
    > and host1x_drm_exit() in the error handling case.
    >
    > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
    > ---
    > drivers/gpu/drm/tegra/host1x.c | 2 ++
    > 1 file changed, 2 insertions(+)
    >
    > diff --git a/drivers/gpu/drm/tegra/host1x.c b/drivers/gpu/drm/tegra/host1x.c
    > index bdb97a5..39629e6 100644
    > --- a/drivers/gpu/drm/tegra/host1x.c
    > +++ b/drivers/gpu/drm/tegra/host1x.c
    > @@ -176,6 +176,7 @@ int host1x_drm_init(struct host1x *host1x, struct drm_device *drm)
    > dev_err(host1x->dev,
    > "DRM setup failed for %s: %d\n",
    > dev_name(client->dev), err);
    > + mutex_unlock(&host1x->clients_lock);
    > return err;
    > }
    > }
    > @@ -203,6 +204,7 @@ int host1x_drm_exit(struct host1x *host1x)
    > dev_err(host1x->dev,
    > "DRM cleanup failed for %s: %d\n",
    > dev_name(client->dev), err);
    > + mutex_unlock(&host1x->clients_lock);
    > return err;
    > }
    > }

    Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-12-02 23:01    [W:7.545 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site