lkml.org 
[lkml]   [2012]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] gpio: add TS-5500 DIO blocks support
Hi Grant,

> Please take a look at either send me a follow-on patch to convert it
> to use gpio-generic, or tell my why gpio-generic isn't appropriate here.

The gpio-generic driver is not appropriate here because Technologic Systems
x86-based platforms do not use a typical GPIO implementation.
To name a few specificities:
- The GPIOs are available through ioport and not iomem
- There are input-only/output-only/input-output lines on the same block
- The number of GPIOs differs between blocks (currently 11, 13 and 14 pins)
- A single bit in a control register drives the direction of 4 input/output
lines, while the register's other bits have different functions.

IMHO these considerations justify a specific GPIO driver to support these
Technologic Systems pin blocks.

Regards,
Vivien


\
 
 \ /
  Last update: 2012-12-20 00:01    [W:0.034 / U:0.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site