Messages in this thread | | | From | Grant Likely <> | Subject | Re: [PATCH] spi: Add the flag indicate to registe new device as children of master or not. | Date | Wed, 19 Dec 2012 16:21:42 +0000 |
| |
On Wed, 19 Dec 2012 09:04:16 +0000, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Wed, Dec 19, 2012 at 04:44:03AM -0500, Jun Chen wrote: > > > This spi_alloc_device function will be called in the spi_new_device > > function to alloc new device as the master. But other way, it is called > > by the of_register_spi_devices function to register new device as the > > children of the master. I will update changlog to add it. > > But why is this a bad thing? You've said what's happening but not why > it's a problem.
spi_devices should always be children of the spi_master. If that is not the case then it is a bug to be fixed.
g.
-- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd.
| |