Messages in this thread | | | From | Venu Byravarasu <> | Date | Wed, 19 Dec 2012 11:08:34 +0530 | Subject | RE: [PATCH] usb: phy: tegra: Using devm API for memory allocation |
| |
> -----Original Message----- > From: Stephen Warren [mailto:swarren@wwwdotorg.org] > Sent: Tuesday, December 18, 2012 10:03 PM > To: Venu Byravarasu > Cc: balbi@ti.com; gregkh@linuxfoundation.org; linux- > kernel@vger.kernel.org; linux-usb@vger.kernel.org > Subject: Re: [PATCH] usb: phy: tegra: Using devm API for memory allocation > > On 12/17/2012 11:21 PM, Venu Byravarasu wrote: > > Using devm_kzalloc for allocating memory needed for PHY > > pointer and hence removing kfree calls to PHY pointer. > > Since the kfree() here used to be in tegra_usb_phy_close() rather than > any remove() function, does it actually make sense to use > devm_kzalloc(); would plain using kzalloc() instead, and not removing > the kfree() calls, be better? >
Stephen, As you mentioned I can replace kmalloc with kzalloc in the original code and push an updated patch. However, I just wanted to understand if there exists any issue in using devm_kzalloc instead of kzalloc?
> When the PHY code gets converted to be an actual probed driver, then > perhaps using devm will make sense.
| |