Messages in this thread | | | Date | Wed, 19 Dec 2012 17:22:30 +0100 | From | Oleg Nesterov <> | Subject | Re: + core_pattern-set-core-helpers-root-and-namespace-to-crashing-process .patch added to -mm tree |
| |
On 12/18, Neil Horman wrote: > > On Tue, Dec 18, 2012 at 09:06:04PM +0100, Oleg Nesterov wrote: > > > Perhaps its best just to restrict this patch to adjusting the root fs location > > > for the chroot case. > > > > Probably... at least for the start. > > > > BTW. Of course this is subjective, but personally I think that "||" > > looks strange. Perhaps it would be better to add something like > > --croot argument? > > > The || is ambiguous with its simmilarity to a shell 'or' command,
Ah, I didn't mean this.
I meant, this is not flexible. We can implement --croot, then we can (may be) add --switch_ns. If you use "||" now for chroot, what will you do for switch_ns?
> but I don't > think the --croot argument is much better on that front, as that then becomes > ambiguous with arguments supplied to the pipe reader directly.
Not sure I understand... why?
> The token should > be leading the pipe_reader string in core_pattern to indicate a change in > environment independent of the executable path.
Do you mean that || at the front is more "visible" ? True, but I am not sure this is that important.
But I won't insist.
Oleg.
| |