Messages in this thread | | | Date | Wed, 19 Dec 2012 13:31:07 +0000 | From | Andy Whitcroft <> | Subject | Re: [PATCH V2] checkpatch: Warn on uapi #includes that #include <uapi/... |
| |
On Tue, Dec 18, 2012 at 05:30:58PM -0800, Joe Perches wrote: > Avoid specifying internal uapi #include paths with uapi/... > as userspace should not use and never see that. > > Neaten message line wrapping above. > > Signed-off-by: Joe Perches <joe@perches.com> > cc: David Howells <dhowells@redhat.com> > --- > scripts/checkpatch.pl | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 054a293..5eab67e 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2238,8 +2238,11 @@ sub process { > my $path = $1; > if ($path =~ m{//}) { > ERROR("MALFORMED_INCLUDE", > - "malformed #include filename\n" . > - $herecurr); > + "malformed #include filename\n" . $herecurr); > + } > + if ($path =~ "^uapi/" && $realfile =~ m@\binclude/uapi/@) { > + ERROR("UAPI_INCLUDE", > + "No #include in ...include/uapi/... should use a uapi/ path prefix\n" . $herecurr); > } > } >
Looks reasonable indeed.
Acked-by: Andy Whitcroft <apw@canonical.com>
-apw
| |