| Date | Tue, 18 Dec 2012 19:37:14 -0800 | Subject | Re: [PATCH v6 02/27] x86, mm: make pgd next calculation consistent with pud/pmd | From | Yinghai Lu <> |
| |
On Fri, Dec 14, 2012 at 6:34 AM, Borislav Petkov <bp@alien8.de> wrote: > On Thu, Dec 13, 2012 at 02:01:56PM -0800, Yinghai Lu wrote: >> Just like PUD_SIZE, and PMD_SIZE next calculation, aka >> round down and add size. > > Why? Please explain more verbosely. > >> also remove not need next checking, just pass end instead. >> later phys_pud_init uses PTRS_PER_PUD checking to exit early >> if end is too big. > > Where? In the for-loop? Where does it check 'end'? >
update to :
--- Subject: [PATCH] x86, mm: make pgd next calculation consistent with pud/pmd
Just like the way we calculate next for pud and pmd, aka round down and add size.
also remove not needed next checking, just pass end with phys_pud_init.
pyhs_pud_init() uses PTRS_PER_PUD to stop its loop early so it could handle big end properly. ---
|