Messages in this thread Patch in this message | | | From | Joe Perches <> | Subject | [PATCH V2] checkpatch: Warn on uapi #includes that #include <uapi/... | Date | Tue, 18 Dec 2012 17:30:58 -0800 |
| |
Avoid specifying internal uapi #include paths with uapi/... as userspace should not use and never see that.
Neaten message line wrapping above.
Signed-off-by: Joe Perches <joe@perches.com> cc: David Howells <dhowells@redhat.com> --- scripts/checkpatch.pl | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 054a293..5eab67e 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2238,8 +2238,11 @@ sub process { my $path = $1; if ($path =~ m{//}) { ERROR("MALFORMED_INCLUDE", - "malformed #include filename\n" . - $herecurr); + "malformed #include filename\n" . $herecurr); + } + if ($path =~ "^uapi/" && $realfile =~ m@\binclude/uapi/@) { + ERROR("UAPI_INCLUDE", + "No #include in ...include/uapi/... should use a uapi/ path prefix\n" . $herecurr); } } -- 1.7.8.112.g3fd21
| |