Messages in this thread Patch in this message | | | Date | Tue, 18 Dec 2012 21:31:59 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] scripts: add checkmaintainers.py |
| |
On Tue, Dec 18, 2012 at 11:34:41AM -0800, Joe Perches wrote: > If no patch is attached, you should get > > ERROR: Does not appear to be a unified-diff format patch
Well, it needs to handle the case where a patch simply and only renames a file.
Then, even if a patch follows:
diff --git a/README b/README.old similarity index 99% rename from README rename to README.old index a24ec89ba442..b0a7aa56c3cc 100644 --- a/README +++ b/README.old @@ -1,3 +1,6 @@ +TEST + + Linux kernel release 3.x <http://kernel.org/> These are the release notes for Linux version 3. Read them carefully, -- it says:
$ git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict - Must be run from the top-level dir. of a kernel tree If I comment out the following hunk:
if (!defined $root) { print "Must be run from the top-level dir. of a kernel tree\n"; exit(2); } then it works, albeit with a bunch of warnings:
Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1558. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1558. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. Use of uninitialized value $root in concatenation (.) or string at ./scripts/checkpatch.pl line 1304. CHECK: Patch renames README to README.old, update MAINTAINERS? ...
Looks like this would need a bit more work.
Thanks.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |