Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] checkpatch: Warn on #include <uapi/... | Date | Tue, 18 Dec 2012 19:17:03 +0000 |
| |
Joe Perches <joe@perches.com> wrote:
> + if ($path =~ "^uapi/") { > + ERROR("UAPI_INCLUDE", > + "#include should not start with uapi/\n" . $herecurr); > }
But does this limit the check only to headers in uapi/ directories? You need to be able to do this outside of a uapi/ directory. For instance, include/linux/fs.h shadows include/uapi/linux/fs.h and so the former has to #include the latter directly as <uapi/linux/fs.h> or else suffer a circular link.
David
| |