Messages in this thread | | | Date | Tue, 18 Dec 2012 09:49:27 -0700 | From | Stephen Warren <> | Subject | Re: [PATCH V2] serial: tegra: add serial driver |
| |
On 12/17/2012 11:59 PM, Laxman Dewangan wrote: > Nvidia's Tegra has multiple uart controller which supports:
A few nits:
That should be NVIDIA.
> .../devicetree/bindings/serial/serial-tegra.txt | 24 +
I strongly object to this name; I believe nvidia,tegra20-hsuart.txt is correct.
> +NVIDIA Tegra20/Tegra30 high speed (dma based) UART controller driver.
DMA, UART (below), ... should be all capitals.
The binding looks reasonable to me. The few parts of the code I looked at look OK.
> diff --git a/include/linux/platform_data/serial-tegra.h b/include/linux/platform_data/serial-tegra.h > +#endif /* _SERIAL_TEGRA_H_ */ > +
There's a blank line at the end of the file.
| |