lkml.org 
[lkml]   [2012]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subjectcheckpatch.pl should check UAPI headers don't #include <uapi/...>
Date

Hi Joe,

Can you make checkpatch.pl check that lines added to UAPI headers don't have
the form:

#include <uapi/...>

or:

#include "uapi/..."

Such as these should be regarded as errors as they will likely break userspace
which shouldn't get to see any uapi/ directories.

An example of this is in:

commit 19bf7f8ac3f8131100027281c495dbbe00cd5ae0
Merge: 787c57c 35fd3dc
Author: Marcelo Tosatti <mtosatti@redhat.com>
Date: Mon Oct 29 19:15:32 2012 -0200

where during the conflict resolution, the following change was made:

- #include <asm/epapr_hcalls.h>
++#include <uapi/asm/epapr_hcalls.h>

I recognise that checkpatch.pl might not have helped in this case since it
isn't normally applied to merged as far as I know.

Thanks,
David


\
 
 \ /
  Last update: 2012-12-18 16:01    [W:0.071 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site