Messages in this thread | | | Date | Mon, 17 Dec 2012 21:40:11 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/2] MCE, AMD: Make MC2 decoding part of amd_decoder_ops as well |
| |
On Mon, Dec 17, 2012 at 12:34:35PM -0800, Joe Perches wrote: > decode_mc2_mce does > > pr_emerg(HW_ERR "MC2 Error: "); > calls > fam_ops->mc2_mce() > which may not emit anything > and if it doesn't, does > pr_emerg(HW_ERR "Corrupted ..."); > on another line leaving a trailing colon without > newline from the pr_emerg above.
Ok, this is in Jacob's patch AFAICT, I'll review those tomorrow but thanks for the heads-up.
> I believe the second pr_emerg should be pr_cont
Actually, it should be
pr_emerg(HW_ERR "\nCorrupted...\n");
to finish the initial pr_emerg.
Thanks.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |