lkml.org 
[lkml]   [2012]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3.7.0 3/9] i82975x_edac.c: cleanup debug code
Em Sun, 16 Dec 2012 02:10:39 +0530
Arvind R <arvino55@gmail.com> escreveu:

> Subject: [PATCH 3.7.0 3/9] i82975x_edac.c: cleanup debug code
>
> modify debug levels to sane levels. Also move random debug code
> into CONFIG_EDAC_DEBUG sections.
> Signed-off-by: Arvind R. <arvino55@gmail.com>
> ---
> i82975x_edac.c | 171 +++++++++++++++++++++++-------------------
> 1 file changed, 97 insertions(+), 74 deletions(-)
>
> --- a/drivers/edac/i82975x_edac.c 2012-12-15 20:18:24 +0530
> +++ b/drivers/edac/i82975x_edac.c 2012-12-15 20:17:58 +0530
...
> @@ -551,11 +583,11 @@ static int i82975x_probe1(struct pci_dev
> layers[1].is_virt_csrow = false;
> mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, sizeof(*pvt));
> if (!mci) {
> + edac_dbg(0, "MC%d failed mc_alloc\n", dev_idx);
> rc = -ENOMEM;
> goto fail1;

Please remove the two last lines. There's no reason why it a driver
should bail out just because debug is enabled.


Cheers,
Mauro


\
 
 \ /
  Last update: 2012-12-17 16:21    [W:0.047 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site