Messages in this thread | | | Date | Sun, 16 Dec 2012 19:17:27 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v3 04/10] x86/microcode_core_early.c: Define interfaces for early loading ucode |
| |
On Sun, Dec 16, 2012 at 06:09:12PM +0000, Yu, Fenghua wrote: > Nothing wrong with taking the parameters. But CPUID_IS is only limited > in this file. There is no other places to use it. I think either way > is ok.
Please don't do this. Anything can happen, someone can copy it somewhere else and try to use it, unification, code movement can all of a sudden break things in the most mysterious ways.
However, if you make the macro definition self-contained. none of those issues will happen.
Thanks.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |