Messages in this thread | | | Date | Fri, 14 Dec 2012 17:53:28 -0800 | Subject | Re: [PATCH 1/1] cpuidle: coupled: fix ready counter decrement | From | Colin Cross <> |
| |
On Fri, Dec 14, 2012 at 3:37 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote: > On Friday, December 14, 2012 10:42:08 AM Sivaram Nair wrote: >> The ready_waiting_counts atomic variable is compared against the wrong >> online cpu count. The latter is computed incorrectly using logical-OR >> instead of bit-OR. This patch fixes that. > > I'm queuing this up for submission as v3.8 material. > > I suppose it should be marked for -stable too? > > Rafael
Acked-by: Colin Cross <ccross@android.com>
Looks suitable for stable.
>> Signed-off-by: Sivaram Nair <sivaramn@nvidia.com> >> --- >> drivers/cpuidle/coupled.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/cpuidle/coupled.c b/drivers/cpuidle/coupled.c >> index 3265844..2a297f8 100644 >> --- a/drivers/cpuidle/coupled.c >> +++ b/drivers/cpuidle/coupled.c >> @@ -209,7 +209,7 @@ inline int cpuidle_coupled_set_not_ready(struct cpuidle_coupled *coupled) >> int all; >> int ret; >> >> - all = coupled->online_count || (coupled->online_count << WAITING_BITS); >> + all = coupled->online_count | (coupled->online_count << WAITING_BITS); >> ret = atomic_add_unless(&coupled->ready_waiting_counts, >> -MAX_WAITING_CPUS, all); >> >> > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center.
| |