Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 2/2] cpuidle: fix sysfs output for power_usage | Date | Sat, 15 Dec 2012 01:03:02 +0100 |
| |
On Friday, December 14, 2012 03:17:37 PM Sivaram Nair wrote: > cpuidle_state->power_usage is signed; so change the corresponding sysfs > ops to output signed value instead of unsigned.
What's actually wrong with printing it as an unsigned int?
Rafael
> Signed-off-by: Sivaram Nair <sivaramn@nvidia.com> > --- > drivers/cpuidle/sysfs.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpuidle/sysfs.c b/drivers/cpuidle/sysfs.c > index 3409429..2fc79cd 100644 > --- a/drivers/cpuidle/sysfs.c > +++ b/drivers/cpuidle/sysfs.c > @@ -232,6 +232,13 @@ static struct cpuidle_state_attr attr_##_name = __ATTR(_name, 0644, show, store) > static ssize_t show_state_##_name(struct cpuidle_state *state, \ > struct cpuidle_state_usage *state_usage, char *buf) \ > { \ > + return sprintf(buf, "%d\n", state->_name);\ > +} > + > +#define define_show_state_u_function(_name) \ > +static ssize_t show_state_##_name(struct cpuidle_state *state, \ > + struct cpuidle_state_usage *state_usage, char *buf) \ > +{ \ > return sprintf(buf, "%u\n", state->_name);\ > } > > @@ -270,7 +277,7 @@ static ssize_t show_state_##_name(struct cpuidle_state *state, \ > return sprintf(buf, "%s\n", state->_name);\ > } > > -define_show_state_function(exit_latency) > +define_show_state_u_function(exit_latency) > define_show_state_function(power_usage) > define_show_state_ull_function(usage) > define_show_state_ull_function(time) > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |