Messages in this thread | | | Date | Fri, 14 Dec 2012 15:05:19 -0500 | From | Dave Jones <> | Subject | Re: power: Add simple poweroff-gpio driver |
| |
On Fri, Dec 14, 2012 at 08:53:40PM +0100, Andrew Lunn wrote: > > > I think it needs to be on the menuconfig, rather than the child options. > > > I don't have OF_GPIO, but I still got asked for the former. > > > > The menuconfig enables a class of drivers (at least theoretically in the > > future, when more such drivers turn up), and there's no reason to > > believe that all of those drivers will depend on OF. So in my opinion, > > making POWER_RESET_GPIO depend on OF makes sense, but making POWER_RESET > > depend on it doesn't. > > I have another driver coming soon which will not depend on OF_GPIO. It > does however depend on OF. Its for a class of boards which have a > microcontroller controlling the main power supply, and sending an > character over a UART port is used to turn the board power off. > > There might also be some legacy drivers which could be moved here > which don't depend on OF at all. > > So i would prefer to keep POWER_RESET generic.
Perhaps a CONFIG_ARCH_WANT_POWER_RESET option for arches that opt-in ?
Dave
| |