lkml.org 
[lkml]   [2012]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: power: Add simple poweroff-gpio driver
    On Fri, Dec 14, 2012 at 09:21:50AM +0100, Andrew Lunn wrote:

    > > Given this seems to be dependant on device-tree, shouldn't there be
    > > some 'depends on' in the kconfig to prevent this showing up on architectures
    > > that don't implement it ?
    > >
    > > > +menuconfig POWER_RESET
    > > > + bool "Board level reset or power off"
    > > > + help
    > > > + Provides a number of drivers which either reset a complete board
    > > > + or shut it down, by manipulating the main power supply on the board.
    > > > +
    > > > + Say Y here to enable board reset and power off
    > > > +
    > > > +config POWER_RESET_GPIO
    > > > + bool "GPIO power-off driver"
    > > > + depends on OF_GPIO && POWER_RESET
    >
    > Don't these depends on here do what you want?

    I think it needs to be on the menuconfig, rather than the child options.
    I don't have OF_GPIO, but I still got asked for the former.


    > > If not, upon seeing this, I suspect many users will ask "how do I know if I need this?"
    > > given there's no mention of the sort of hardware this is useful on.
    >
    > Its a generic driver. I know its useful on various Marvell kirkwood
    > and orion5x devices. I've also heard it useful on some Tegra boards.
    >
    > Are you asking i list these boards?

    No, but at least mentioning the architecture might have clued me in quicker that this
    wasn't some now ACPI-ism when I saw it on x86.

    Dave



    \
     
     \ /
      Last update: 2012-12-14 17:01    [W:3.029 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site