Messages in this thread | | | Date | Fri, 14 Dec 2012 09:40:58 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] [libata] scsi: fix Null pointer dereference on disk error |
| |
On 12/13/2012 03:12 AM, Xiaotian Feng wrote: > Following oops were observed when disk error happened: > > [ 4272.896937] sd 0:0:0:0: [sda] Unhandled error code > [ 4272.896939] sd 0:0:0:0: [sda] Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK > [ 4272.896942] sd 0:0:0:0: [sda] CDB: Read(10): 28 00 00 5a de a7 00 00 08 00 > [ 4272.896951] end_request: I/O error, dev sda, sector 5955239 > [ 4291.574947] BUG: unable to handle kernel NULL pointer dereference at (null) > [ 4291.658305] IP: [] ahci_activity_show+0x1/0x40 > [ 4291.730090] PGD 76dbbc067 PUD 6c4fba067 PMD 0 > [ 4291.783408] Oops: 0000 [#1] SMP > [ 4291.822100] last sysfs file: /sys/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/sw_activity > [ 4291.934235] CPU 9 > [ 4291.958301] Pid: 27942, comm: hwinfo ...... > > ata_scsi_find_dev could return NULL, so ata_scsi_activity_{show,store} should check if atadev is NULL. > > Signed-off-by: Xiaotian Feng <dannyfeng@tencent.com> > Cc: Jeff Garzik <jgarzik@redhat.com> > Cc: James Bottomley <JBottomley@Parallels.com> > Cc: stable@kernel.org > Cc: linux-ide@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/ata/libata-scsi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-)
applied
| |