Messages in this thread Patch in this message | | | Subject | [PATCH v2 3/6] iio: dac: ad5504: Don't set error code to voltage_uv | From | Axel Lin <> | Date | Fri, 14 Dec 2012 20:06:29 +0800 |
| |
regulator_get_voltage() may return negative error code. Add error checking to avoid setting error code to voltage_uv.
Signed-off-by: Axel Lin <axel.lin@ingics.com> --- v2: check if ret is negative value drivers/iio/dac/ad5504.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 242bdc7..1e9a1f4 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -296,7 +296,11 @@ static int __devinit ad5504_probe(struct spi_device *spi) if (ret) goto error_put_reg; - voltage_uv = regulator_get_voltage(reg); + ret = regulator_get_voltage(reg); + if (ret < 0) + goto error_disable_reg; + + voltage_uv = ret; } spi_set_drvdata(spi, indio_dev); -- 1.7.9.5
| |