Messages in this thread | | | Date | Fri, 14 Dec 2012 17:16:25 +0530 | Subject | Re: [PATCH] dw_dmac: remove redundant check | From | Viresh Kumar <> |
| |
On 14 December 2012 15:09, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > There is no need to check the callback_required parameter, due to we check the > callback pointer to be a non-NULL. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/dma/dw_dmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c > index 92f33af..3c8acfa 100644 > --- a/drivers/dma/dw_dmac.c > +++ b/drivers/dma/dw_dmac.c > @@ -364,7 +364,7 @@ dwc_descriptor_complete(struct dw_dma_chan *dwc, struct dw_desc *desc, > > spin_unlock_irqrestore(&dwc->lock, flags); > > - if (callback_required && callback) > + if (callback) > callback(param); > }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
| |