Messages in this thread | | | Date | Fri, 14 Dec 2012 15:45:49 +0400 | From | Konstantin Khlebnikov <> | Subject | Re: [PATCH] ata: uncomment ata_timing for XFER_PIO_SLOW |
| |
Borislav Petkov wrote: > On Fri, Dec 14, 2012 at 03:01:37PM +0400, Konstantin Khlebnikov wrote: >> This patch uncomments ata timings for XFER_PIO_SLOW, >> otherwise ata_timing_find_mode() returns NULL and kernel crashes in >> pacpi_set_dmamode() after null-pointer dereference. >> >> The same problem was mentioned recently in debug patch v3.7-rc5-72-gcd705d5 >> ("libata debugging: Warn when unable to find timing descriptor based on xfer_mode") >> >> I'm not sure about this patch, because I have no idea what this XFER_PIO_SLOW > > No, this is already fixed by: > > > Btw, this patch will go to stable since I can't find it in 3.7, I'm > guessing Jeff will send it to Linus soonish since it is in his NEXT > branch. > > Until that happens, you could test 3.7 by cherrypicking the patch above > ontop of it or by simply applying it by hand since it is only two lines. > > Or, you could wait and test -rc1 when it comes out after the world ends :-).
Ah, thanks. Sorry for noise. I'll check this again in current linux-next.
> >> means and why this bug so rare (3 times during 4 days boot-reboot test) I caught >> this on completely ordinary PC with nvidia MCP61 chipset, sata hdd and ide dvd-rom. >> >> Signed-off-by: Konstantin Khlebnikov<khlebnikov@openvz.org> >> Signed-off-by: Borislav Petkov<bp@alien8.de> >> Signed-off-by: Jeff Garzik<jgarzik@redhat.com> > > Btw, just FYI, this is not how S-o-b chaining works. Take a look > at<Documentation/SubmittingPatches> for details on how it is done > correctly.
ouch :facepalm: how I missed this... just copy-paste error. sorry again.
> > HTH. >
| |