lkml.org 
[lkml]   [2012]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH 04/12] pps: pps_parport: fix oops on module unloading
From
Date
Seems like port->cad is NULL for unused ports

Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: Rodolfo Giometti <giometti@enneenne.com>

---

[ 0.151192] BUG: unable to handle kernel NULL pointer dereference at (null)
[ 0.151759] IP: [<ffffffffa2de3048>] parport_detach+0x24/0x95 [pps_parport]
[ 0.153875] Process rmmod (pid: 22117, threadinfo ffff880061174000, task ffff8800613db000)
[ 0.153875] Call Trace:
[ 0.153875] [<ffffffffa064c49c>] parport_unregister_driver+0x51/0x8b [parport]
[ 0.153875] [<ffffffffa2de364f>] pps_parport_exit+0x17/0x20 [pps_parport]
[ 0.153875] [<ffffffff8110e976>] sys_delete_module+0x328/0x3d2
[ 0.153875] [<ffffffff8168e7e8>] tracesys+0xe1/0xe6
---
drivers/pps/clients/pps_parport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pps/clients/pps_parport.c b/drivers/pps/clients/pps_parport.c
index e1b4705..7e9bcd4 100644
--- a/drivers/pps/clients/pps_parport.c
+++ b/drivers/pps/clients/pps_parport.c
@@ -194,7 +194,7 @@ static void parport_detach(struct parport *port)
struct pps_client_pp *device;

/* FIXME: oooh, this is ugly! */
- if (strcmp(pardev->name, KBUILD_MODNAME))
+ if (!pardev || strcmp(pardev->name, KBUILD_MODNAME))
/* not our port */
return;



\
 
 \ /
  Last update: 2012-12-14 12:42    [W:0.089 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site