lkml.org 
[lkml]   [2012]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] drivers/w1/masters/mxc_w1.c: use devm_ functions
On Thu, Dec 13, 2012 at 11:18:53AM +0100, Julia Lawall wrote:
> On Thu, 13 Dec 2012, Dan Carpenter wrote:
>
> > On Wed, Dec 12, 2012 at 01:25:56AM +0400, Evgeniy Polyakov wrote:
> > > I suppose mdev will be automatically freed, but who will release
> > > mdev->clk and other private members of mdev structure?
> >
> > + mdev->clk = devm_clk_get(&pdev->dev, NULL);
> >
> > ->clk is now a devm pointer as well.
>
> Thanks for the suggestion. I will submit a patch shortly.
>

Huh? I think there is a miscommunication here. I was trying to
explain that your original patch handles releasing ->clk.

I've reviewed the patch again and I still don't see a problem with
it. What will you change when you resubmit?

regards,
dan carpenter



\
 
 \ /
  Last update: 2012-12-13 13:01    [W:0.047 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site