lkml.org 
[lkml]   [2012]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] timekeeping: Add persistent_clock_exist flag
On 12/12/2012 06:05 PM, Feng Tang wrote:
> In current kernel, there are several places which need to check
> whether there is a persistent clock for the platform. Current check
> is done by calling the read_persistent_clock() and validating the
> return value.
>
> Add such a flag to make code more readable and call read_persistent_clock()
> only once for all the checks.
Sorry.. What the actual benefit of this patch set? (Usually with
changelogs its better to explain why you're doing something, rather then
just what you're doing.)

Maybe I'm missing something, but it seems this doesn't change the
resulting logic of the code, does it? As I thought we already check
read_persistent_clocks() output (and make sure its null) before using
the rtc HCTOSYS_DEVICE.

thanks
-john



\
 
 \ /
  Last update: 2012-12-14 02:41    [W:0.072 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site