lkml.org 
[lkml]   [2012]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC/RFT] regulator: core: Fix continuous_voltage_range case in regulator_can_change_voltage
Hello,

On 12/12/2012 2:22 AM, Axel Lin wrote:
> Regulator drivers with continuous_voltage_range flag set allows not setting
> n_voltages. Thus if continuous_voltage_range is set, check the constraint range
> instead.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/core.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 0f65b24..d7448ad 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1885,9 +1885,15 @@ int regulator_can_change_voltage(struct regulator *regulator)
> struct regulator_dev *rdev = regulator->rdev;
>
> if (rdev->constraints &&
> - rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE &&
> - (rdev->desc->n_voltages - rdev->desc->linear_min_sel) > 1)
> - return 1;
> + (rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE)) {
> + if (rdev->desc->n_voltages - rdev->desc->linear_min_sel > 1)
> + return 1;
> +
> + if (rdev->desc->continuous_voltage_range &&
> + rdev->constraints->min_uV && rdev->constraints->max_uV &&
> + rdev->constraints->min_uV != rdev->constraints->max_uV)
> + return 1;
> + }
>
> return 0;
> }
>

This change looks reasonable, I've missed the fact that there is a
support for regulators with continuous voltage range. This change also
shows that the n_voltages based workaround used earlier by mmc core was
indeed only a hack and regulator_can_change_voltage() approach is much
cleaner solution.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center



\
 
 \ /
  Last update: 2012-12-13 10:21    [W:0.057 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site