Messages in this thread |  | | Date | Thu, 13 Dec 2012 19:37:00 +0100 | From | Borislav Petkov <> | Subject | Re: [TRIVIAL PATCH 16/26] x86: Convert print_symbol to %pSR |
| |
On Thu, Dec 13, 2012 at 10:23:10AM -0800, Joe Perches wrote: > m->ip is a u64 so, when compiling x86-32, there's a new warning > "cast to pointer from integer of different size". This isn't new > different behavior, just a new warning. The previous print_symbol > took a ulong and the u64 was silently truncated. > > CC arch/x86/kernel/cpu/mcheck/mce.o > arch/x86/kernel/cpu/mcheck/mce.c: In function ‘print_mce’: > arch/x86/kernel/cpu/mcheck/mce.c:246:4: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > If appropriate, the code could be changed to > > (void *)(unsigned long)m->ip
Can we explicitly cast it to what it is so that we can be explicit as to what we're casting it? IOW:
(void *)(__u64)m->ip;
Does that even work on 32bit?
Also, does the compiler bitch about this useless cast when building with W=123?
Thanks.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |