Messages in this thread | | | Date | Thu, 13 Dec 2012 08:48:26 +0000 | From | Mark Brown <> | Subject | Re: [RFC/RFT][PATCH 1/4] regulator: core: Allow specify activate_[reg|bit] for regmap based voltage_sel operations |
| |
On Thu, Dec 13, 2012 at 04:44:08PM +0800, Axel Lin wrote: > Some DVM regulators needs to update activate_bit after setting vsel_reg to > initiate voltage change on the output. This patch adds activate_reg and > activate_bit to struct regulator_desc and update > regulator_set_voltage_sel_regmap() to set activate_bit of activate_reg when > activate_bit is set.
I'm not convinced about the naming here... how about apply rather than activate? Not sure if it shouldn't be specific to voltage setting either.
| |